Stric Standards fiwes 10 years 5 months ago #1

  • DJ Anubis
  • Localtime: 10:18
  • Europe/Bucharest
  • Posts: 4
Hi,

While testing and translating, found some Strict Standards warnings, easealy fixed:

/administrator/components/com_spamprotect/views/logs/view.html.php, line 24 should be:
public function display($tpl = null)
to prevent
PHP Strict Standards:  Declaration of JSpamProtectViewLogs::display() should be compatible with JViewLegacy::display($tpl = NULL) in /var/www/clients/client1/web4/web/administrator/components/com_spamprotect/views/logs/view.html.php

Same with dashboard and about views.

The last one is in about/view.html.php, method getVersionInfo
	protected function getVersionInfo()
	{
		$row = new stdClass();
		$row->extension = JTable::getInstance('extension');
		$row->extension->load(array('name' => 'com_spamprotect'));
without declaring $row, PHP complains about
PHP Warning:  Creating default object from empty value in /var/www/clients/client1/web4/web/administrator/components/com_spamprotect/views/about/view.html.php on line 45
Those are not errors, but rely on code quality, specially against PHP 5.4/5.5.
The administrator has disabled public write access.

Re: Stric Standards fiwes 10 years 5 months ago #2

  • Dobrescu Cristian
  • Dobrescu Cristian's Avatar
  • Developer
  • Bucharest
  • Localtime: 10:18
  • Europe/Bucharest
  • Posts: 1005
Thank you for the feedback, we will address these in a future release.
thePHPfactory Customer Support
The administrator has disabled public write access.